Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added PingService #480

Merged
merged 5 commits into from
Oct 29, 2024
Merged

added PingService #480

merged 5 commits into from
Oct 29, 2024

Conversation

mystical-prog
Copy link
Contributor

@mystical-prog mystical-prog commented Oct 25, 2024 •
edited
Loading

Ping Protocol Implementation

Issue #344
Updated from #409

How was it fixed?

I have created a new PingService class inside the libp2p/host/ping.py file

To-Do

  • Write tests for the new PingService implementation
  • Run make lint

Cute Animal Picture

put a cute animal picture link inside the parentheses

@mystical-prog mystical-prog changed the title added PingService WIP - added PingService Oct 25, 2024
@kazzmir
Copy link
Contributor

kazzmir commented Oct 26, 2024

tangentially related, lint errors in the ping.py example

examples/ping/ping.py:29:24: E711 comparison to None should be 'if cond is not None:'
examples/ping/ping.py:35:9: B001 Do not use bare `except:`, it also catches unexpected events like memory errors, interrupts, system exit, and so on.  Prefer `except Exception:`.  If you're sure what you're doing, be explicit and write `except BaseException:`.
examples/ping/ping.py:35:9: E722 do not use bare 'except'

@mystical-prog mystical-prog changed the title WIP - added PingService added PingService Oct 26, 2024
@mystical-prog mystical-prog marked this pull request as ready for review October 26, 2024 19:45
pacrob
pacrob approved these changes Oct 29, 2024
View reviewed changes
Copy link
Member

@pacrob pacrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@pacrob pacrob merged commit 410e6d4 into libp2p:main Oct 29, 2024
17 checks passed
@pacrob pacrob mentioned this pull request Nov 3, 2024
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pacrob pacrob pacrob approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mystical-prog @kazzmir @pacrob